[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] RFC: Changing the language of individual KDE programs
From:       David Faure <faure () kde ! org>
Date:       2007-03-28 9:32:29
Message-ID: 200703281132.30205.faure () kde ! org
[Download RAW message or body]

On Wednesday 28 March 2007, Krzysztof Lichota wrote:
> > Oh, this is Qt3/kde3 code. I hope QVariant can contain the type of data you want \
> > to put into it then...
> 
> I do not see the option to put arbitrary pointer in QVariant in Qt3 docs.

OK I think the Qt3 way would be to just have a QMap in the dialog that associates the \
button with whatever it needs to be associated with. Then you don't need this void* \
usage and this extra class [which even pollutes the header that you want to make \
public :)]. I strongly recomment a QMap<QPushButton*, SomeStruct> to avoid the \
new/deletes and risks of memleaks.

> I will change it to d-pointer, I think this class should be exported so
> that apps which do not have Help menu could open this dialog using other
> means.
OK. It feels weird to add new api to 3.x at this point though.


-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


[prev in list] [next in list] [prev in thread] [next in thread]