[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Plugin manager issues
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-02-22 3:07:58
Message-ID: 200702212008.06030.aseigo () kde ! org
[Download RAW message or body]


On February 21, 2007, Rafael Fernández López wrote:
> Well, revisiting this code I see this is just crap. If you close that
> window (still with the unique-applet added to kicker), reopen that window,
> and remove the unique-applet, it won't be added to the list, since
> PluginManager::self() is another different instance. I have seen probably

a) this belongs on panel-devel, not kde-core-devel

b) any idea why addapplet.cpp was completely reformatted to use tabs instead 
of spaces? this file now has no useful svn log and violates the coding style 
for that application.

c) PluginManager::self() is a singleton so it's always the same object

d) the reason for this bug seems obvious: populateApplets doesn't add an entry 
if it's already on the panel and unique; pluginDestroyed() is connected to 
updateAppletList(), which just call search(QString) which just filters 
applets that are shown (and populateApplets wouldn't have shown it). what 
needs to happen is populateApplets should add all items then call search with 
an empty string which will hide uniqueApplets. then when pluginDestroyed() is 
called it'll show up again.

and please: spaces, not tabs. =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]