From kde-core-devel  Tue Feb 13 19:13:38 2007
From: Urs Wolfer <uwolfer () kde ! org>
Date: Tue, 13 Feb 2007 19:13:38 +0000
To: kde-core-devel
Subject: Re: kdelibs coding style
Message-Id: <200702132013.38682.uwolfer () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=117139401925973
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1882692.dyzVI5xKEe"

--nextPart1882692.dyzVI5xKEe
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Tuesday 13 February 2007, Dirk Mueller wrote:=20
> On Monday, 12. February 2007 23:45, Urs Wolfer wrote:
> > the files, which are edited in any way by a developer. But to be honest:
> > Who has done that? People change some lines, but nobody cares about the
> > formating.
>
> Sure they do. I've not seen many violations. But if there are, it certain=
ly
> makes sense people to make aware that they break the style.

My statement was probably a bit harsh. Sorry about that. But while reading=
=20
commit logs, I see a _lot_ commits without changing anything than just some=
=20
lines. These new lines have mostly a good style, but the old, messy code=20
stays there. That's why I proposed a mass formatting. I would like to have=
=20
clean and consistent code, at least in kdelibs. But I see that is not the=20
opinion of all; I respect that.

> I've been thinking about adding the style check to the commit log
> generation script so that we have an automatic review of patches as they'=
re
> being committed but first I need a good perl script that does check
> reliably for offending bugs ;)

It would probably be a good idea. But it could also probably annoy develope=
rs,=20
who just want to fix a bug and not correct the formating of the whole code =
in=20
the file.

Btw: Another idea would be to run astyle as special "formatting" user, like=
=20
scripty, in one go. This way everybody will see that the code was just=20
formatted, and not edited.

Bye
urs

--nextPart1882692.dyzVI5xKEe
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBF0g3iooBDqI2Jn8gRAh3TAJ9ml+bVt/eKIa53g0FyK9MqsTNmlgCaAu2P
ZDHC6TrI3dNNgdbAZAi2qbE=
=ZQu3
-----END PGP SIGNATURE-----

--nextPart1882692.dyzVI5xKEe--