From kde-core-devel  Mon Feb 12 23:05:15 2007
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: Mon, 12 Feb 2007 23:05:15 +0000
To: kde-core-devel
Subject: Re: kdelibs coding style
Message-Id: <200702121605.16181.aseigo () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=117132154205294
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart3123807.vF8TTQIhap"

--nextPart3123807.vF8TTQIhap
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On February 12, 2007, Urs Wolfer wrote:
> First of all, I'm aware of the age of this thread. But nothing has changed
> since then. That's why I'm writing again about this issue.

let's not rehash the discussion. it was beaten to death. and then beaten to=
=20
death again. and once more just to get it out of system. and then again=20
because it felt good the first three times. ;)

IOW, as jaison said: "Nooooooooooooooooooo!"

> Who has done that? People change some lines, but nobody cares about the
> formating.

so ..... i'm nobody? jeeze, i've been feeling a bit disenfranchised lately =
but=20
boy this takes it a whole new level ;-P

> * update the Library Code Policy [1] with the example by Zack. The example
> is the Trolltech Qt Coding Style. That means we follow at least in kdelibs
> our underlying library in formatting.

i think this makes sense, yes. please add it to the appropriate location on=
=20
devnew.

> * run astyle [2] over kdelibs trunk. I have tested that [3] and the result
> is quite good and follows the style described above. Try it!

no. it was decided not to do this in the thread the last time and for good=
=20
reasons. let's not restart conversation just because we can in hopes the=20
result is closer to our personal preferences =3D)

> * svn blame: reformated lines don't show the "right" revision and author.
> BUT: the same would happen when we format every single file when we edit =
it
> anyways. If we would like to have "nicer" code, there is no way around th=
at
> issue.

you're missing the obvious fact that if you modify a method and you change =
the=20
style of the code you are editting that the commit log is still accurate,=20
which is why this is the preferred mechanism. this is not theory, i've done=
=20
it in other code bases. and yes, i'm doing it as i touch things in kdelibs =
as=20
well. it won't happen overnight, but patience is a -virtue- for a reason =
=3D)

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

=46ull time KDE developer sponsored by Trolltech (http://www.trolltech.com)

--nextPart3123807.vF8TTQIhap
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQBF0PKs1rcusafx20MRAiTpAKCl9+/MHsAnA2v2T7Yjp9AJYl5WcACghElv
+H/XDgrYckTq+mBmyMPZJrQ=
=fmxQ
-----END PGP SIGNATURE-----

--nextPart3123807.vF8TTQIhap--