From kde-core-devel  Sun Jan 14 22:06:59 2007
From: Olivier Goffart <ogoffart () kde ! org>
Date: Sun, 14 Jan 2007 22:06:59 +0000
To: kde-core-devel
Subject: Re: Normalizing signals and slots
Message-Id: <200701142307.03182.ogoffart () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=116881254926350
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart2548970.LyoBicLSJj"

--nextPart2548970.LyoBicLSJj
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Le dimanche 14 janvier 2007 22:35, Thiago Macieira a =C3=A9crit=C2=A0:
> jos poortvliet wrote:
> >Op zondag 14 januari 2007, schreef Matt Rogers:
> >> I disagree. Normalizing signals and slots doesn't make that much of a
> >> real difference in terms of speed. We don't gain that much by doing it
> >> for more than kdelibs and parts of kdebase.
> >
> >now i'm of course not qualified to comment on this, but i wonder - how
> > much work is it? i mean, maybe it's not worth changing stuff for, but
> > it could be part of coding guidelines?
>
> Requiring programmers to normalise is not worth it. Sometimes, the code
> looks uneven or just plain ugly when compared to the rest of the code.
> But the most important aspect is that we're humans and sometimes we get
> it wrong.

Anyway, this is already a part of the guidelines, and IMO it should not.

> That's why running a script is probably better. If we do it once just
> before the KDE 4.0 release and then once per year, we should be mostly
> fine already.

or maybe just for released code,  but not the one in subversion.

--nextPart2548970.LyoBicLSJj
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBFqqmHz58lY8jWrL0RAmdEAKCFy2/vMrrLV2Gs3P8wkXhP3oTLrwCfbaax
ahwlR0AS+h/OCdyz7ByZY18=
=sxlW
-----END PGP SIGNATURE-----

--nextPart2548970.LyoBicLSJj--