[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: A KSelectAction dedicated to QTextCodec selection ?
From:       "Michel Hermier" <michel.hermier () gmail ! com>
Date:       2006-10-20 11:19:05
Message-ID: 2e631f490610200419p21468646xf65703f5e8d6ad4 () mail ! gmail ! com
[Download RAW message or body]


I noticed while preparing the changes locally, that I need one of my
local change for KSelectAction (well only a return change, but the
patch adds a little more).
So I delay the commit for now.

Can someone maintaining KSelectAction review the patch.
What changed with this patch:
- bool setCurrentAction(QAction *, DeselectionMode mode) should be
more safe, checking that the action really belongs to the action group
before activating the action. Also added an extra parameter with
default value to mimic the old behaviour. This extra parameter allow
to not deselect the previous action in case of falure to select the
action.

- bool setCurrent* now use the new setCurrentAction instead of
reinventing the wheel.

Is it ok to commit ? and should I wait for monday ?

Michel

["kselectaction.diff" (application/octet-stream)]

[prev in list] [next in list] [prev in thread] [next in thread]