From kde-core-devel Thu Aug 24 10:12:02 2006 From: Lubos Lunak Date: Thu, 24 Aug 2006 10:12:02 +0000 To: kde-core-devel Subject: Re: kdelibs coding style Message-Id: <200608241212.02378.l.lunak () suse ! cz> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=115641435829960 On Wednesday 23 August 2006 23:06, David Faure wrote: > On Wednesday 23 August 2006 16:47, Lubos Lunak wrote: > > So we're going to have a guide that's pretty strict even about things > > like placement of spaces but not actually require it? > > That would be my idea, yes. A "best practice" or "recommendation". > Just like many things about kdelibs, like putting the variables into the d > pointer, or writing API docs ;) So none of it will be required? If that's the intention it should be clearly said. Not that I'd mind, I find many of the items in the Qt styleguide that don't have a better reason than matter-of-taste to be bad for readability anyway (trailing {, missing indentation in switch, etc.). > We still do this for fun, so let's not make it a work environment where you > only get a patch in if it follows 500 rules, with the need for 20 revisions > of the patch until it actually follows them all. > > > How about we then make a > > list of really required things[*] and call the rest just > > "recommendations" or whatever, because that's what it's going to be > > anyway? (Do I have to say that I told you?) > > > > [*] > > - Indent by 4 spaces, no tabs > > Would be a good first step. > > > - Try to make it readable, use common sense, > > Those two things are too vague to be of any use in a list of required > things :) Everyone interprets that differently in the end. And? Poor readability is 90% inconsistent indenting and 10% simply writting messy code. What else would you want to be required, "no space after a cast"? How does that matter? > > follow the style of the file > > Was already the requirement/recommendation, yes. > > > > Well, I think we can wrap this up now - editor-specific config-files > > > have been added to kdelibs (like .emacs-dirvars), all we need is to add > > > the kdelibs-coding-style to some webpage, I guess on > > > developer.kde.org... > > Hmm the real question is whether to remove the "( foo )" space insertion > from kde-emacs :) -- Lubos Lunak KDE developer -------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: l.lunak@suse.cz , l.lunak@kde.org Lihovarska 1060/12 tel: +420 284 028 972 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http//www.suse.cz