[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KClearableLineEdit
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2006-08-23 10:48:43
Message-ID: 200608231248.43413.hausmann () kde ! org
[Download RAW message or body]


On Wednesday 23 August 2006 09:27, Aaron J. Seigo wrote:
> attached is a class that implements a line edit with an embedded clear
> button. the intention is to replace all those lineedits with the clear
> button next to them. why?
>
> a) they currently look ugly by breaking layouts out
> b) they unnecessarily increase the visual noise with More Buttons
> c) being external to the line edit they are currently not very well
> associated with the widget they act upon.
>
> the only downside to this new class (besides bugs i am not aware of and
> some unwanted flickering on resizing, all of which are fixables as issues
> arise) is that i'm not sure what the accessibility impact would be; worst
> case is that this class would need to export via QAccessible that it has a
> clear function? not sure ...
>
> i also implemented this as a subclass of KLineEdit rather than embed the
> functionality into KLineEdit since KLineEdit is already a pretty hairy
> beast and i didn't want to add to that.

One minor thing: I think the resizeEvent re-implementation should call the 
base classes's one at the end.

Simon

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]