[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Introducing LikeBack - Quick Feedback from Beta-Testers
From:       Allen Winter <winter () kde ! org>
Date:       2006-08-14 17:56:55
Message-ID: 200608141356.55395.winter () kde ! org
[Download RAW message or body]

On Sunday 13 August 2006 17:05, Sébastien Laoût wrote:
> Le Dimanche 13 Août 2006 19:26, Tom Albers a écrit :
> > And krazy finds some issues:
> > http://www.englishbreakfastnetwork.org/krazy/reports/playground/utils/ktu/i
> >ndex.html
> 
> Attached are the fixed likeback.cpp and likeback.h.
> Also with Aaron J. Seigo patch applied.
> 
> 
> Note: The test "Check for adding single char string to a QString..." also 
> search in comments! It referenced that line (and others) as an error:
> 
> 	//QString namedMailExpString = "[.]*[ \\t]+<" + mailExpString + ">";
> 
> Correction:
> 
> 	//QString namedMailExpString = "[.]*[ \\t]+<" + mailExpString + '>';
> 
> This is a good thing here, because it's effectively a code that can be 
> uncommented, but is it wanted to check in comments?
> 
I just changed this Krazy check to skip comments.
Some of the Krazy checks skip comments, while others do not.
I'm working to have them behave consistently and always skip comments.

> 
> Oh, and it complained about licence has a wrong address but does not tell me 
> what is the address I should have added.
> I suppose this line:...
> 
>     59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
> 
> ... should be replaced with:
> 
>     51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> 
> (from a random file in websvn.kde.org)
> 
See  kdesdk/scripts/fixfsfaddr.sed 


-- 
KDE: Same Thing We Do Everyday... Try to Conquer the World


[prev in list] [next in list] [prev in thread] [next in thread]