[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KSelectAction
From:       Clarence Dang <dang () kde ! org>
Date:       2006-07-24 14:35:45
Message-ID: 200607250035.48579.dang () kde ! org
[Download RAW message or body]

On Sunday 23 July 2006 02:30, Andreas Zehender wrote:
> Clarence Dang schrieb:
> >Does KSelectAction work for anyone?  I'm trying to get the KolourPaint
> > zoom action working.

I've got it working for okular and KolourPaint now.  I will check KOffice 
shortly.  Editing the text directly is not yet supported - should be by the 
end of this week.

> KSelectAction even crashes here on application startup (KPovModeler).

Out of curiosity, how was KSelectAction before my commits?

> See backtrace below.
>
> I made a clean co and build of qt-copy and kdelibs this morning.

Does the attached patch work?  It's late so I haven't tested it yet.  I'm glad 
KPovModeler compiles - I'll include it in my testing.

Thanks,
Clarence

["kselectaction-crash.diff" (text/x-diff)]

Index: kselectaction.cpp
===================================================================
--- kselectaction.cpp	(revision 565816)
+++ kselectaction.cpp	(working copy)
@@ -639,9 +639,9 @@
     }
   }
 
-  kDebug () << "\t\tcurrent action still selected? " << curAction->isChecked () << endl;
+  kDebug () << "\t\tcurrent action still selected? " << (curAction && curAction->isChecked ()) << endl;
   // 1 or 0 actions checked case (in that order)?
-  return curAction->isChecked () ? sa->actions ().indexOf (curAction) : -1;
+  return (curAction && curAction->isChecked ()) ? sa->actions ().indexOf (curAction) : -1;
 }
 
 // A plain "QVariant (action)" results in a bool being stored.  So all


[prev in list] [next in list] [prev in thread] [next in thread]