[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdelibs coding style
From:       "Jaison Lee" <lee.jaison () gmail ! com>
Date:       2006-07-22 22:44:27
Message-ID: 2d720bd30607221544l7f6305d9n87c1ec793e07025d () mail ! gmail ! com
[Download RAW message or body]

> And yes, not having an
> indentation style is also expressing trust --- it's the project saying to the
> contributor "we're sure you can make your code nice and readable".

The problem is that obviously doesn't work. kdelibs looks like a mess.
This has proven itself to be something that we can't simply trust a
contributor with.[1] If the whole we-trust-you-make-it-pretty-please
worked we wouldn't be having this conversation in the first place. So
apparently I'm forced to conclude that some contributors require the
help of a preferred coding style so they don't commit something worthy
of an obfuscated C contest.

With the exception of your kdepim comment, I appreciate you wording
your argument better than others have in this thread, but you make it
seem like this is being done for no reason when this is obviously not
the case.

[1] kutils/kmultitabbar.cpp, kimgio/psd.cpp, kimgio/tga.cpp,
kstyles/light/lightstyle-v{2,3}.cpp, khtml/rendering/font.cpp, etc.
etc. etc. And that's without looking very hard.
[prev in list] [next in list] [prev in thread] [next in thread]