[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Endian bug in KNetwork::KIpAddress
From: Thiago Macieira <thiago () kde ! org>
Date: 2006-07-22 13:18:25
Message-ID: 200607221518.26061.thiago () kde ! org
[Download RAW message or body]
Nadeem Hasan wrote:
>On Saturday 22 July 2006 04:50, you wrote:
>> Calling ntohl should be preferred in the isClass* functions, since it
>> wouldn't change the address data, that other sections of code must be
>> using already.
>>
>> I have no development environment here either. I cannot do any
>> changes.
>
>Ok...I have a near blind patch attached. It compiles, but I cannot
> verify that it actually works (though it should). I would really like
> this fix to get into 3.5.4 so If someone can give me a green light, I
> will commit.
Please don't #include <arpa/inet.h> in the public header.
Add a new function that returns the ntohl of the IPv4 address and call
ntohl from it.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
[Attachment #3 (application/pgp-signature)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic