[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDE_NO_EXPORT
From:       Thiago Macieira <thiago () kde ! org>
Date:       2006-07-18 20:11:44
Message-ID: 200607182212.03062.thiago () kde ! org
[Download RAW message or body]


Allen Winter wrote:
>It seems to me that public library classes should either be KDE_EXPORTed
> or KDE_NO_EXPORTed. True?

Not exactly. They should be XXXXX_EXPORT'ed when they are public. There's 
no need to no-export private ones.

KDE_EXPORT should never be used directly.

>So, what I'm really asking is... for public classes that are not marked
> with the FOO_EXPORT macro, would it be ok to mark them with the
> KDE_NO_EXPORT macro?  (assuming that they really are not for exporting
> and we simply didn't forget to FOO_EXPORT them).

That's unnecessary cruft in our headers. No compiler requires that flag.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]