From kde-core-devel  Thu Jul 13 03:31:29 2006
From: Matt Rogers <mattr () kde ! org>
Date: Thu, 13 Jul 2006 03:31:29 +0000
To: kde-core-devel
Subject: Re: [PATCH]: FIx missing connect() in KEditToolbar
Message-Id: <200607122231.29870.mattr () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=115276151509039

On Wednesday 12 July 2006 20:32, Jason Harris wrote:
> Hello,
>
> When trying to implement editable toolbars for KStars, I ran into problems.
> The KEditToolbar window would appear and provide the correct behavior, but
> the Ok/Apply/Default buttons didn't do anything[1].
>
> After some poking around, I eventually concluded that the problem is that
> the clicked signals for these buttons aren't actually connected to
> anything.  The slots slotApply(), slotOk() and slotDefault() exist, but are
> not connected.
>
> KEditToolbar was derived from KDialogBase in KDE-3.5, which provided the
> connect() statements for these buttons.  I'm guessing that when
> KEditToolbar was ported to KDialog, the connects were forgotten.
>
> Anyway, I have attached a small patch that adds the connect statements to
> kedittoolbar.cpp.  I understand that this class will likely see huge
> changes when LiveUI comes, but it's a pretty simple patch, so I thought I'd
> submit it for consideration anyway.
>
> Warning: I am getting an application crash when I close the KEditToolbar
> window, but I'm not able to track it down.  DrKonqi is not giving a useful
> BT, and when I run it through gdb, it doesn't crash.  Here's the DrKonqi
> BT:
>
>
[snip bt]
> Despite the crash, the modified toolbars are retained when the app gets
> restarted.
>
> Jason
>
> [1]: For more details, see my kde-devel thread:
> http://lists.kde.org/?l=kde-devel&m=115266838112453&w=2

If it works, I say commit it.
--
Matt