[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KPF
From:       Rik Hemsley <rik () rikkus ! info>
Date:       2006-06-04 10:59:01
Message-ID: 4482BCF5.2020205 () rikkus ! info
[Download RAW message or body]

Adam Tulinius wrote:
> i saw the wish on bugs.kde.org about the possibility of making kpf allow 
> unlimited bandwidth. well, couldn't do that, but since the limits seems to be 
> 1024kBps i made a patch that only allows the bandwidth to be a value between 
> 1 og 1024 kBps so people don't think anything is wrong when they notice the 
> low throughoutput.

The patch looks like the best solution, thanks.

The only problem is that I'm not able to test it.

I'm CC:ing this to kde-core-devel in the hope that someone might have 
the time to have a look at it.

That's if this message actually gets through without me being subscribed 
at this address...

Cheers,
Rik

["diff" (text/plain)]

Index: ConfigDialogPage.cpp
===================================================================
--- ConfigDialogPage.cpp	(revision 547771)
+++ ConfigDialogPage.cpp	(working copy)
@@ -53,7 +53,7 @@
 //    l_connectionLimit_  = new QLabel(i18n("Connection &limit"), this);
 
     sb_listenPort_      = new QSpinBox(1,  65535, 1, this);
-    sb_bandwidthLimit_  = new QSpinBox(1,     999999, 1, this);
+    sb_bandwidthLimit_  = new QSpinBox(1,     1024, 1, this);
 //    sb_connectionLimit_ = new QSpinBox(1,     9999,   1, this);
 
     l_serverName_       = new QLabel(i18n("&Server name:"),      this);
Index: ServerWizard.cpp
===================================================================
--- ServerWizard.cpp	(revision 547771)
+++ ServerWizard.cpp	(working copy)
@@ -147,7 +147,7 @@
 
     sb_listenPort_      = new QSpinBox(1,  65535, 1, page2_);
 
-    sb_bandwidthLimit_  = new QSpinBox(1,     999999, 1, page3_);
+    sb_bandwidthLimit_  = new QSpinBox(1,       1024, 1, page3_);
 //    sb_connectionLimit_ = new QSpinBox(1,     9999,   1, page4_);
 
     char hostname[255];
Index: PropertiesDialogPlugin.cpp
===================================================================
--- PropertiesDialogPlugin.cpp	(revision 547771)
+++ PropertiesDialogPlugin.cpp	(working copy)
@@ -331,7 +331,7 @@
     d->l_serverName->setEnabled(canPublish);
 
     d->sb_listenPort      = new QSpinBox(1000,  999999, 1, w);
-    d->sb_bandwidthLimit  = new QSpinBox(1,     999999, 1, w);
+    d->sb_bandwidthLimit  = new QSpinBox(1,       1024, 1, w);
 //    d->sb_connectionLimit = new QSpinBox(1,     9999,   1, w);
     d->le_serverName      = new QLineEdit( w);
     d->le_serverName->setEnabled(canPublish);


[prev in list] [next in list] [prev in thread] [next in thread]