--nextPart42455714.qqHlsxxv1u
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Saturday 22 April 2006 01:36, Christoph Bartoschek wrote:

> - kuickshow/src/defaultswidget.cpp:270
>
> Why not &&?

=46ixed.

> - kmrml/kmrml/lib/watcher_stub.cpp:50
>
> result is only initialized when line 42 is executed.

This is DCOP generated code. The return value is only valid when the status=
 is=20
set to "CallSucceeded" which happens only in line 43. A client must check t=
he=20
validity with DCOPStub.ok() before using the result.

> - kooka/kookaview.cpp:881
>
> If dirKfi  is NULL as indicated by line 864, then line 881 crashes.

=46ixed.

> - kooka/scanpackager.cpp:1246
>
> If e is NULL as indicated by line 1244, then line 1246 crashes.

Should never happen, removed the condition-chec.

> - kooka/scanpackager.cpp:443
>
> If item is NULL as indicated by line 421, then line 429 crashes.

Should never happen, but fixed anyway.

> - kooka/scanpackager.cpp:255
>
> If kfi is NULL as indicated by line 220, then line 255 crashes.

=46ixed.

> - kuickshow/src/kuickshow.cpp:839
>
> If steps =3D=3D 0, then item is NULL here.

Never happens, but I added a guard.

> - kuickshow/src/defaultswidget.cpp:179
>
> If imFiltered is NULL as indicated by line 150, then line 179 crashes.

Never happens, removed the guard in line 150.

> - libkscan/img_canvas.cpp:588,593,598,603

Added fall-through comments.

> - kfile-plugins/jpeg/exif.cpp:352

No problem, but added a break.

> Lines where boolean expressions are used in non-boolean contexts:
>
> I suspect that at least the lines marked with !!! are bugs
> -----------------------------------------------------------------
>
> - kuickshow/src/kuickshow.cpp:522
> - kuickshow/src/kuickshow.cpp:521

No bugs there.

Thanks a bunch,
Carsten

--nextPart42455714.qqHlsxxv1u
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----

iQEVAwUAREpilaWgYMJuwmZtAQKhgQf+M/YgxIHz0X30385KCiRFS5FQPvSMNJ4R
mgKw7myxRg0Pn5lK3anv5Z30Y0QiAvILEiBK5WynJ3OOGOPoEcUbm+kb+C59IDa8
5IEry0kxm8LgVc1PR79GhFcbJ4C1m+PMeRN7ijrCrB4TbqT719Z9jgLCHpdAoZk6
rsfi3DUrjatLlVIN/6/0IWOx0WXctr8DTjXXsrkcc0eU0n/3oCZrvFO2Hk6G8n47
nyadYGOrxvSjOLZ1vFTi7ZuCf1dzIdXrO1MLq7tAXZPAghSLt9dA4Olgl7E2NMaV
619kVXVv4pCLTy3RCMQkathazMIZaDpThhivBaMPLcn7LUnsb+9JMA==
=btYz
-----END PGP SIGNATURE-----

--nextPart42455714.qqHlsxxv1u--