[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Suspicious code in kdenetwork-3.5.2
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2006-04-21 8:38:09
Message-ID: 200604211038.13778.ogoffart () kde ! org
[Download RAW message or body]


Thanks.

I fixed problems found in kopete, but only in 
libkopete (but not avdevice)
kopete
msn
history
texteffect



Le Mercredi 19 Avril 2006 00:05, Christoph Bartoschek a écrit :
> ------------------------------------------------------------------
> Misc problems:
> ------------------------------------------------------------------
>

> - kopete/plugins/history/historydialog.cpp:470
>
> mSearch is NULL here. No effect.

Fixed


> - kopete/protocols/msn/msnsocket.cpp:301
>
> When buffer is deleted in line 296, is it possible that it is used in line
> 301?

Fixed


> ------------------------------------
> Problems involving the NULL pointer:
> ------------------------------------

> - kopete/libkopete/kopetemessage.cpp:769
>
> If testCodec is NULL as indicated by line 760, then line 769 crashes.

Fixed

> - kopete/plugins/history/historylogger.cpp:574
>
> Maybe currentContact is NULL here.

I'm not sure this is possible, but fixed anyway.

> - kopete/protocols/msn/outgoingtransfer.cpp:99
>
> If m_file is NULL as indicated by line 88, then line 99 crashes.


Fixed

>
> - kopete/libkopete/knotification.cpp:468
>
> If mc is NULL as indicated by line 463, then line 468 crashes.

false positive.  (but changed)


> -----------------------------------------------------------------
> Cases from switch statements that fall through in some cases but
> do not have a fall through comment as in most such cases.
> ------------------------------------------------------------------
>
> - kopete/libkopete/kopeteonlinestatus.cpp:122

nice catch.

> - kopete/kopete/chatwindow/chatview.cpp:697

added the comment.

> - kopete/kopete/contactlist/kopetecontactlistview.cpp:2073


fixed

> - kopete/plugins/texteffect/texteffectplugin.cpp:157
> - kopete/plugins/texteffect/texteffectplugin.cpp:150
> - kopete/plugins/texteffect/texteffectplugin.cpp:143
> - kopete/plugins/texteffect/texteffectplugin.cpp:136
> - kopete/plugins/texteffect/texteffectplugin.cpp:129
> - kopete/plugins/texteffect/texteffectplugin.cpp:122
> - kopete/plugins/texteffect/texteffectplugin.cpp:115
> - kopete/plugins/texteffect/texteffectplugin.cpp:108

added comments

> -----------------------------------------------------------------
> Lines where boolean expressions are used in non-boolean contexts:
>
> I suspect that at least the lines marked with !!! are bugs
> -----------------------------------------------------------------
>
> - kopete/libkopete/kopetechatsession.cpp:412 (b is a bool)

fixed

> - kopete/kopete/addcontactwizard/addcontactwizard.cpp:220

fixed

> - kopete/libkopete/private/kopeteviewmanager.cpp:176
> - kopete/libkopete/private/kopeteviewmanager.cpp:178
> - kopete/libkopete/private/kopeteviewmanager.cpp:183
> - kopete/libkopete/private/kopeteviewmanager.cpp:187

fixed

> - kopete/libkopete/kopeteaccountmanager.cpp:93

fixed

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]