[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KFileInfo: using shared data
From:       David Faure <faure () kde ! org>
Date:       2006-04-14 16:23:07
Message-ID: 20060414162307.GC9915 () ktown ! kde ! org
[Download RAW message or body]

On Fri, Apr 14, 2006 at 06:17:44PM +0200, Thiago Macieira wrote:
> Hamish Rodda wrote:
> >Hi,
> >
> >I was looking at KFileInfo and noticed that it was marked as "/// KDE4
> > TODO: make them refcounted, e.g. using QSharedMimeData."
> >
> >So, I started out porting it over to be implicitly shared using
> > QSharedData. Went pretty easily, for the most part.
> >
> >However, changing from pointers shared copies doesn't work well, because
> > when a change is made it means that all of the other instances don't
> > get the change.
> >
> >Is the plan to make this class explicitly shared?
> 
> QSharedMimeData is supposed to be about implicitly sharing.

Yes. But I didn't really think this through when adding the TODO.

I think using KSharedPtr would be better, in fact, since this is about
refcounting the file items, not about making changes to them without
affecting other copies.

David.

[prev in list] [next in list] [prev in thread] [next in thread]