[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Suspicous code in kdelibs-3.5.2
From:       Thiago Macieira <thiago () kde ! org>
Date:       2006-04-09 9:38:17
Message-ID: 200604091138.17970.thiago () kde ! org
[Download RAW message or body]


Lubos Lunak wrote:
>> -----------------------------------------------------------------
>> Cases from switch statements that fall through in some cases but
>> do not have a fall through comment as in most such cases.
>> ------------------------------------------------------------------
>>
>> - kdecore/kglobalaccel_x11.cpp:246
>
> Actually intended.

Is it intended to be confusing? :-)

This is what the test catches: switch statements that fall through (which 
is quite ok) without a comment saying "yes, fall through. I did not 
forget to break here".

-- 
Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
  thiago.macieira (AT) trolltech.com     Trolltech AS
    GPG: 0x6EF45358                   |  Sandakerveien 116,
    E067 918B B660 DBD1 105C          |  NO-0402
    966C 33F5 F005 6EF4 5358          |  Oslo, Norway

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]