[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Suspicous code in kdelibs-3.5.2
From:       Waldo Bastian <bastian () kde ! org>
Date:       2006-04-07 5:02:04
Message-ID: 200604062202.10769.bastian () kde ! org
[Download RAW message or body]


On Wednesday 05 April 2006 08:19, George Staikos wrote:
> On Wednesday 05 April 2006 10:26, Christoph Bartoschek wrote:
> > - kio/misc/kwalletd/kwalletd.cpp:430
> >
> > Line 414 indicates that kpd can be NULL. When the while loop at line 420
> > is entered line 424 crashes.
>
>   I guess my code is too tricky for your tool. :-)  The only way that kpd
> can be null is if "b->isOpen()" (and some other criteria).  Maybe
> misleading, but not a bug.

Make sure to add some comments then that explain your assumptions and why the 
code is valid.

Cheers,
Waldo
-- 
Linux Client Architect - Channel Platform Solutions Group - Intel Corporation

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]