[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] Preload popup menus for the desktop (3.5)
From:       David Faure <faure () kde ! org>
Date:       2006-04-05 18:14:01
Message-ID: 200604052014.01662.faure () kde ! org
[Download RAW message or body]

On Wednesday 05 April 2006 01:42, Scott Wheeler wrote:
> On Wednesday 05 April 2006 1:19, David Faure wrote:
> > Hmm. I can't see how the plugins would be particularly slower than the rest
> > of the popupmenu-setup code, they do the same kind of thing: creating
> > actions and plugging them. Although arkplugin.cpp does a new KConfig each
> > time which could easily be changed to a kstatic-deleted static KConfig *
> > (but you said kconfig was fast).
> 
> I don't claim to understand it, but for me it's somewhat moot since we allow 
> third parties to install stuff there and one poorly written service menu 
> entry could make Konq / KDesktop suck without any clear link between the 
> plugin and the sucking.
That's true.

> > Anyway you gave percentages in one mail and milliseconds in the next one
> > so I'm a bit confused with the timing data :)
> 
> Well, the numbers that I'm getting are in ms, when I divide that by the total 
> I get a percentage.  ;-)  
Sure, but without all the numbers it's a bit hard to compare "this code takes 50ms"
and "this other code takes 20%" ;-)

> If you actually want to see what I'm working with  
It's the numbers that would interest me more ;)

>  +#include <kprofilemethod.h>
Cool - happy to see that my 4-year old hack is still useful :)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]