From kde-core-devel  Fri Mar 31 15:41:30 2006
From: "Benjamin Reed" <rangerrick () gmail ! com>
Date: Fri, 31 Mar 2006 15:41:30 +0000
To: kde-core-devel
Subject: Re: Farewell KAccel, you have served us well
Message-Id: <57eba2250603310741s5f9d401bo6b3447219bb1120e () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=114381976808180

On 3/27/06, Hamish Rodda <rodda@kde.org> wrote:

> Now that QAction has taken over the shortcut management, it is time to remove
> KAccel from kdelibs.

judging by the amount of KAccel stuff that changed in trunk, I take it
this has been committed now?

I'm running into issues with Qt/Mac in that kdeui/kglobalaccel has not
excised all the X11 bits, it looks like:

---(snip!)---
Building CXX object kdeui/CMakeFiles/kdeui.dir/kglobalaccel_x11.o
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.h:67: error: 'XEvent'
has not been declared
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.h:69: error: expected
',' or '...' before '*' token
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.h:69: error: ISO C++
forbids declaration of 'XEvent' with no type
/usr/include/X11/Xlib.h:510: error: conflicting declaration 'typedef
struct _XDisplay Display'
/Users/ranger/cvs/kdelibs/kdecore/kapplication.h:45: error: 'Display'
has a previous declaration as 'typedef void Display'
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp: In member
function 'bool KGlobalAccelImpl::grabKey(int, bool)':
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp:125: error:
incomplete type 'QX11Info' used in nested name specifier
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp:126: error:
incomplete type 'QX11Info' used in nested name specifier
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp:128: error:
incomplete type 'QX11Info' used in nested name specifier
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp:128: error:
incomplete type 'QX11Info' used in nested name specifier
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp: At global scope:
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp:146: error:
prototype for 'bool KGlobalAccelImpl::x11Event(XEvent*)' does not
match any in class 'KGlobalAccelImpl'
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.h:67: error:
candidate is: virtual bool KGlobalAccelImpl::x11Event(int*)
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp: In member
function 'bool KGlobalAccelImpl::x11Event(XEvent*)':
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp:155: error:
invalid conversion from 'XEvent*' to 'int'
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp:155: error:  
initializing argument 1 of 'bool KGlobalAccelImpl::x11KeyPress(int)'
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp: At global scope:
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp:178: error:
prototype for 'bool KGlobalAccelImpl::x11KeyPress(const XEvent*)' does
not match any in class 'KGlobalAccelImpl'
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.h:69: error:
candidate is: bool KGlobalAccelImpl::x11KeyPress(int)
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp: In member
function 'bool KGlobalAccelImpl::x11KeyPress(const XEvent*)':
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp:182: error:
incomplete type 'QX11Info' used in nested name specifier
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp:183: error:
incomplete type 'QX11Info' used in nested name specifier
/Users/ranger/cvs/kdelibs/kdeui/kglobalaccel_x11.cpp:193: error:
incomplete type 'QX11Info' used in nested name specifier
make[2]: *** [kdeui/CMakeFiles/kdeui.dir/kglobalaccel_x11.o] Error 1
make[1]: *** [kdeui/CMakeFiles/kdeui.dir/all] Error 2
make: *** [all] Error 2
---(snip!)---

I thought we had pure-qt-based implementations of accelerator stuff
now; does there need to be a _mac implementation of this?  Or is this
just vestiges of things that haven't been ported yet?