On Tuesday 14 February 2006 16:42, Tobias Koenig wrote:
> On Tue, Feb 14, 2006 at 01:34:41PM +0100, Simon Hausmann wrote:
> > On Tuesday 14 February 2006 13:21, Tobias Koenig wrote:
>
> Hi Simon,
>
> > I can't comment on the actual implementation, but I find the fact that
> > QX11EmbedWidget and QX11EmbedContainer are maintained in
> > qt/src/gui/kernel a fairly convincing argument :)
>
> Ok ;)
>
> After a grep over kdelibs and kdebase it seems QXEmbed is only used in
> KSystemTray (which just inherits from it and calls
> QXEmbed::initialize()), kicker and javaapplets.
>
> All these pieces of code just call QXEmbed::initialize(), which seems to
> be obsolete anyway. (Comments?)

 The difference between QXEmbed and the two QX11Embed* classes is that QXEmbed 
tries to be both, instances of QXEmbed should work like QX11EmbedContainer 
and static functions should automagically work like QX11EmbedWidget after 
QXEmbed::initialize() is called. So usage of QXEmbed::initialize() should be 
replaced by making the respective widget that will be embedded inherit from 
QX11EmbedWidget.

> NSPlugin doesn't use QXEmbed at all,

 It does, your grep seems to be broken :).

> but should make use of 
> QX11EmbedWidget to provide proper focus handling IMHO.
>
> I'll take a look these classes and try to port them.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak@suse.cz , l.lunak@kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/