[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Problem with tm_gmtoff in kjs
From:       Harri Porten <porten () froglogic ! com>
Date:       2006-01-19 10:27:51
Message-ID: Pine.LNX.4.44.0601191125440.22192-100000 () alster ! froglogic ! com
[Download RAW message or body]

On Thu, 19 Jan 2006, George Staikos wrote:

> > It removes the platform specific #ifdef's we had in before. Instead of
> > t.tm_gmtoff we used -timezone.
>
>   ... and that code was also buggy.

What was the problem? We have that code in use here, too, so I'd like to
fix it if necessary.

>  I did some work to get rid of so many
> different [broken] cases for different platforms.  If something isn't
> portable, it's not hard to fix though.  Make a patch, and if it's good
> enough, I'll work to get it into webkit also.

No matter how it's solved I bet we are going to end up with an #ifdef
again.

Harri.

[prev in list] [next in list] [prev in thread] [next in thread]