From kde-core-devel  Sat Jan 14 13:24:04 2006
From: Holger =?iso-8859-1?q?Schr=F6der?= <holger-kde () holgis ! net>
Date: Sat, 14 Jan 2006 13:24:04 +0000
To: kde-core-devel
Subject: Re: [Patch] KProgress / KProgressDialog
Message-Id: <200601141424.04853.holger-kde () holgis ! net>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=113724506713487

On Saturday 14 January 2006 12:17, Urs Wolfer wrote:
> After the comments on k-c-d and the discussion on #kde4-devel here the new
> version of my patch.
>
> Changes:
> * renamed KProgress to KProgressBar to have a name more like QProgressBar.
> I think this should be no problem since the *Progress* stuff has changed a
> lot und we must update all files using these classes. But still kprogress.
> {h/cpp}, because in kprogress.{h/cpp} are KProgressBar and KProgressDialog.
>
would it make sense to split both classes into their own cpp/h files, so that 
we have every class in its own files ? so KProgrssBar goes into kprogressbar.
{h,cpp} and KProgressDialog goes into kprogressdialog.{h,cpp}

> * Remove the most functions from KProgressBar since they were redundant
> with the Qt4 QProgressBar. Only setFormat(const QString & format) and
> advance(int offset) remaining.
>
> dfaure: Thanks for your hints.
> ogoffart: Removed qApp->processEvents() in slotAutoShow. I haven't seen
> that. Thanks.
>
> Ok to commit these changes?
>
> Bye
> urs

-- 
regards,

Holger Schröder