[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [Patch] KProgress / KProgressDialog
From:       David Faure <faure () kde ! org>
Date:       2006-01-14 11:32:16
Message-ID: 200601141232.17078.faure () kde ! org
[Download RAW message or body]

On Saturday 14 January 2006 12:17, Urs Wolfer wrote:
> After the comments on k-c-d and the discussion on #kde4-devel here the new 
> version of my patch.
> 
> Changes:
> * renamed KProgress to KProgressBar to have a name more like QProgressBar. I 
> think this should be no problem since the *Progress* stuff has changed a lot 
> und we must update all files using these classes. But still kprogress.
> {h/cpp}, because in kprogress.{h/cpp} are KProgressBar and KProgressDialog.
> 
> * Remove the most functions from KProgressBar since they were redundant with 
> the Qt4 QProgressBar. Only setFormat(const QString & format) and advance(int 
> offset) remaining.
> 
> dfaure: Thanks for your hints.
> ogoffart: Removed qApp->processEvents() in slotAutoShow. I haven't seen that. 
> Thanks.
> 
> Ok to commit these changes?

Did you write a test program to test it? If so, please commit it.
Otherwise please adapt kdeui/tests/kprogresstest.cpp
Thanks!

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]