[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: readEntry and booleans
From:       David Faure <faure () kde ! org>
Date:       2006-01-05 9:42:29
Message-ID: 200601051042.30257.faure () kde ! org
[Download RAW message or body]

On Wednesday 04 January 2006 21:34, Thomas Braxton wrote:
> forgot to attach the diffs :)
> in the second diff kconfigtest issues a warning about loss of information 
> instead of crashing.

In general I don't like to bring crashes onto users; but in this case I fail
to see how application code could use the right types most of the times
and incompatible types now and then; it would have to be pretty generic
code to end up doing that.... So IMHO the Q_ASSERT is fine, to catch such
an unlikely programming error early. Adding the warning in addition can't hurt,
for the release case :) 

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]