[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] "close" action shortcut
From:       Thomas Zander <zander () kde ! org>
Date:       2005-12-03 8:36:51
Message-ID: 200512030936.56501.zander () kde ! org
[Download RAW message or body]


On Saturday 03 December 2005 00:36, Jarosław Staniek wrote:
> FIX1. win32 only:
> CTRL+F4 shortcut is well known and expected to work on win32: added it
> as default shortcut; CTRL+W moved as alternative.
>
> FIX2. After FIX1, "close_window" action in KMDI can just use
> KStdAccel::close()
>
>
> OK to commit?

I'm not one to object; but I do want to get off my chest that platform 
defaults being ifdefed in sourcecode is not really a proper solution in 
my mind.

Don't we already have ways to do this without touching the sources? I'd 
hate to see the same functionality implemented twice in two different 
ways. (making one useless, or worse)
-- 
Thomas Zander

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]