[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KScrollView
From:       Benjamin Meyer <ben () meyerhome ! net>
Date:       2005-11-28 15:40:23
Message-ID: 200511281238.28760.ben () meyerhome ! net
[Download RAW message or body]


On Monday 28 November 2005 7:48 am, Stephan Kulow wrote:
> Am Montag, 28. November 2005 13:31 schrieb Benjamin Meyer:
> > According to lxr.kde.org the KScrollView class isn't used anywhere in
> > KDE. Can this be removed?
>
> Short answer: no.
>
> Long answer: http://bugs.kde.org/show_bug.cgi?id=76082
>
> Greetings, Stephan

I was pretty sure that we had a policy that there has to be two applications 
that use a class before it can go into kdelibs.  I see khtml used it for a 
*very* short time, but that it was removed (it was BIC).  Also searching the 
core mailinglist I don't see the introduction of this class on the list at 
all for review.

On the technical side the approach seems wrong (which would have been caught 
if it was posted to the list).  It will *only* be able to scroll those 
widgets that have it as a parent, many widgets like QTreeView will of course 
not ever and thus not get the feature.  What you really want is a class that 
takes a widget and scrolls "it" in a smooth fashion.

So right now there is a class that isn't used by anyone that uses 
Q3ScrollView. I think this class should be moved to khtml or playground and 
re-introduced later when it is actually used.

I am also guilty of missing this file when it was first added.  I have created 
a search to flag any new files to prevent this problem in the future.

-Benjamin Meyer

-- 
aka icefox
Public Key: http://www.icefox.net/public_key.asc

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic