[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] two patches for 114771
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2005-11-25 11:16:38
Message-ID: 200511251216.38965.nicolasg () snafu ! de
[Download RAW message or body]

On Wednesday 23 November 2005 14:26, S.Çağlar Onur wrote:
> Çarşamba 23 Kasım 2005 15:14 tarihinde, Stefan Teleman şunları yazmıştı:
> > here are two patches based on 3.5rc1 (attached) for bug 114771.
>
> Jut saw while looking, from ktimezones.cpp
>
> -"/bin/awk" << "'{print \"??\\t+9999+99999\\t\" $2}'";
> + ......<< " | " << "/usr/bin/nawk " << "'{ print \"??\\t+9999+99999\\t\"
> $2 }' > " << temp....
>
> I think nawk not comes with all distros so hardcoding this into code is not
> a good idea, using /bin/awk is much more safer for compatibilty.

I am just thinking:

- if I remember well, the KDE3 build system defines $AWK, it would be better 
to use that name instead of a fixed file name for awk.

- also probably using Perl directly is preferable, as Perl is mandatory for 
KDE (compile time and run time).

Have a nice day!

>
> just my 2 cents


[prev in list] [next in list] [prev in thread] [next in thread]