--nextPart2106059.de61M5znrB
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Tuesday 08 November 2005 5:00 pm, David Jarvie wrote:
> Now that the time zone classes have been updated, there is a need to be
> able to handle date/times which have an associated time zone. I attach a
> proposed new kdecore class, KDateTime, which represents a date/time with =
an
> associated time zone. The aim is to make time zone handling as automatic =
as
> possible when manipulating dates and times. Its interface is very similar
> to QDateTime, but it is not inherited from QDateTime mainly because
> QDateTime's methods are not virtual.

You don't inherit from QDateTime so I recommend coping the api exactly when=
=20
possible.

> The code compiles, but I until I finish the test program is untested. Note
> that if the new class is committed, the time zone classes will need to be
> amended to handle the new class.
>
> Comments please. (Note that I am going away and won't be able to respond
> for a few days.)

Header simple comments:

kill the @file, there is no point to it.
remove the _ start and end of the define
timeZone v.s. timezone - one should be picked
setTime_t argument can just be "seconds"
Should there be an operator=3D for QDateTime?

The docs look good (from quickly skimming), thank you for taking the time. =
=20
The only think I would think you might want to add an example code usage to=
=20
the class intro.

Can you create an autotest using the qttestlib for the class?

=2DBenjamin Meyer

=2D-=20
aka icefox
Public Key: http://www.icefox.net/public_key.asc

--nextPart2106059.de61M5znrB
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQBDdLF+1rZ3LTw38vIRAuJmAKCTI7UlbxoAbMyy5dyc1IeJ61PDdQCgnVEa
jyFb5xc2EgA4YoZKIWOCXTU=
=vT01
-----END PGP SIGNATURE-----

--nextPart2106059.de61M5znrB--