From kde-core-devel  Sat Oct 29 21:06:16 2005
From: Ralf Habacker <ralf.habacker () freenet ! de>
Date: Sat, 29 Oct 2005 21:06:16 +0000
To: kde-core-devel
Subject: Re: [Patch] fix compile kdecore with msvc
Message-Id: <200510292306.16826.ralf.habacker () freenet ! de>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=113062000231680

Am Samstag, 29. Oktober 2005 22:26 schrieb Thiago Macieira:
> Christian Ehrlicher wrote:
> >Changes:
> >network/kresolver.cpp
> >- masked '#warning' - is gnuc-specific
>
> ok
applied

> >network/kresolver.h
> >- don't export KResolverResults to avoid compiler errors (*)
>
> Not acceptable. Don't commit this.

Christian, what kind  of compiler message do you get ? 

> >network/ksocketdevice.cpp
> >- don't include ksockssocketdevice in windows to avoid linker errors
>
> Understandable. I want to fix that later by other means.
>
> >- indentation fixes (tabulator -> spaces)
>
> Superfluous.

are there any astyle rules available ?  It would make live much easier :-)  

> >- add kde_ioctl because ioctl isn't available in windows
> >network/syssocket.h
> >- add kde_ioctl (**)
>
> Ok, makes sense.
applied

> >* there is imho no need to export KResolverResults because nobody
> >derivates a class from KResolverResults. And if you really want to
> >export this class, you have to implement all functions QList<T> defines
> >because otherwise when someone wants to use a function you forgot to
> >implement he will get a linker error.
>
> Your argument doesn't make sense. Functions that were not overridden will
> be inherited from QList<T>.

Ralf