[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Proposed new kdelibs time zone classes
From:       David Jarvie <lists () astrojar ! org ! uk>
Date:       2005-10-17 20:27:39
Message-ID: 200510172127.40052.lists () astrojar ! org ! uk
[Download RAW message or body]

On Monday 17 Oct 2005 11:54, Benjamin Meyer wrote:
> On Sunday 16 October 2005 7:07 pm, David Jarvie wrote:
> > Here is my proposed new code for the kdelibs/kdecore time zone classes.
> > I've attached new code rather than diffs since the changes are very
> > substantial (although some parts of the existing code is still retained).
> > The aim of the changes is to provide base classes to use for deriving
> > non-system time zone classes. In particular, this will form a basis for
> > implementing time zone classes for iCalendar time zone data, which should
> > allow some long standing bugs in kdepim to be fixed. The current time
> > zone implementation is only really suited to dealing with system time
> > zones, not time zone information from other sources.
> >
> > See the discussion on 29th and 30th September in this mailing list
> > (http://lists.kde.org/?l=kde-core-devel&m=112800361918888&w=2 etc.) for
> > more details.
> >
> > Note that I haven't yet tested the KTzfile* classes - I'm in the process
> > of doing that now. The system time zone handling doesn't depend on them,
> > so they aren't so important.
> >
> > Can I commit?
>
> Docs and tests!  Yah :)
>
> Only real nitpick I can see from a quick glance is that
>  KTzfileTimezoneData,  KTimezoneData, and KTimezoneSource, don't have a
> private class.
>
> With the tests if you can convert them to use qttestlib that would be
> appreciated.  qttestlib has an xml output format which is very usefull for
> generating reports from.

Here is a revised set of files with private classes in all classes, and using 
qttestlib. KTzfileTimezone* classes are now included in the tests.

-- 
David Jarvie.
KAlarm author and maintainer.
http://www.astrojar.org.uk/linux/kalarm.html

["ktimezones.tar.gz" (application/x-tgz)]
["conf.diff" (text/x-diff)]

--- configure.in.in	2005-10-08 16:53:52.000000000 +0100
+++ /tmp/configure.in.in	2005-10-16 23:44:54.926491704 +0100
@@ -378,3 +378,15 @@
 
 KDE_INIT_DOXYGEN([The KDE API Reference], [Version $VERSION])
 KDE_CHECK_BINUTILS
+
+AC_CACHE_CHECK(for tm_gmtoff in struct tm, ac_cv_struct_tm_gmtoff,	
+  AC_TRY_COMPILE([
+    #include <time.h>
+  ], [
+    struct tm tm;
+    tm.tm_gmtoff = 1;
+  ], ac_cv_struct_tm_gmtoff=yes, ac_cv_struct_tm_gmtoff=no))
+if test $ac_cv_struct_tm_gmtoff = yes; then
+  AC_DEFINE(HAVE_TM_GMTOFF, 1, [Define if you have a tm_gmtoff member in struct tm])
+fi
+


[prev in list] [next in list] [prev in thread] [next in thread]