From kde-core-devel  Mon Oct 17 08:56:39 2005
From: Benjamin Meyer <ben () meyerhome ! net>
Date: Mon, 17 Oct 2005 08:56:39 +0000
To: kde-core-devel
Subject: Re: Proposed new kdelibs time zone classes
Message-Id: <200510170654.40094.ben () meyerhome ! net>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=112953939902613
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart4358958.2D9gzjjXv3"

--nextPart4358958.2D9gzjjXv3
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Sunday 16 October 2005 7:07 pm, David Jarvie wrote:
> Here is my proposed new code for the kdelibs/kdecore time zone classes.
> I've attached new code rather than diffs since the changes are very
> substantial (although some parts of the existing code is still retained).
> The aim of the changes is to provide base classes to use for deriving
> non-system time zone classes. In particular, this will form a basis for
> implementing time zone classes for iCalendar time zone data, which should
> allow some long standing bugs in kdepim to be fixed. The current time zone
> implementation is only really suited to dealing with system time zones, n=
ot
> time zone information from other sources.
>
> See the discussion on 29th and 30th September in this mailing list
> (http://lists.kde.org/?l=3Dkde-core-devel&m=3D112800361918888&w=3D2 etc.)=
 for
> more details.
>
> Note that I haven't yet tested the KTzfile* classes - I'm in the process =
of
> doing that now. The system time zone handling doesn't depend on them, so
> they aren't so important.
>
> Can I commit?

Docs and tests!  Yah :)

Only real nitpick I can see from a quick glance is that
 KTzfileTimezoneData,  KTimezoneData, and KTimezoneSource, don't have a=20
private class.

With the tests if you can convert them to use qttestlib that would be=20
appreciated.  qttestlib has an xml output format which is very usefull for=
=20
generating reports from.

=2DBenjamin Meyer


=2D-=20
aka icefox
Public Key: http://www.icefox.net/public_key.asc

--nextPart4358958.2D9gzjjXv3
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQBDU4Lw1rZ3LTw38vIRAuFrAKCpcpAqCNBuK1MCQGW9p4olRpcdFgCdEilb
3dL5o6o2GQpkSGoAgEfoTCk=
=1kod
-----END PGP SIGNATURE-----

--nextPart4358958.2D9gzjjXv3--