[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KTar + KTempFile + QFilePrivate::openExternalFile
From:       David Faure <faure () kde ! org>
Date:       2005-09-19 14:28:56
Message-ID: 200509191628.57307.faure () kde ! org
[Download RAW message or body]

On Monday 19 September 2005 15:45, Sascha Cunz wrote:
> Am Montag 19 September 2005 01:20 schrieb David Faure:
> > On Saturday 17 September 2005 10:53, Sascha Cunz wrote:
> > > Though, Qt3 docs says too, that calling QFile::close() after calling
> > > QFile::open(FILE*, OpenMode) does nothing but flush the file.
> > >
> > > All i wanted to say is, that the comment in KTar that says "File has to
> > > be closed to be used for KArchive::setDevice(QIODevice*)" is plain wrong.
> > > Because it ain't closed according to Qt-Docs.
> >
> > It's closed in the sense that isClosed() is true and than open() will work,
> > that's all that matters as far as that comment goes.
> 
> Well, then the comment should be changed. Anyone new to it looking into the 
> source and comparing it to the docs should conclude that there's something 
> wrong.

I disagree. To me "calling QFile::close" is exactly "closing the file".
What happens at the underlying level doesn't matter.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]