[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kcompletion tests
From:       Benjamin Meyer <ben () meyerhome ! net>
Date:       2005-09-14 10:54:16
Message-ID: 200509140712.17359.ben () meyerhome ! net
[Download RAW message or body]


On Tuesday 13 September 2005 9:22 am, Thomas Braxton wrote:
> Hi,
> I want to add these files to svn but I wanted to get some feedback on them
> before I do that. These tests all pass on current/head. This is my first
> attempt at writing unit tests is there anything I may have missed? Are
> there any tests that look wrong?

First off, thank you for writing a test.  It is very much appreciated.  One 
thing you probably want to add is tests for the signals.  It is very easy to 
add with QSignalSpy

http://doc.trolltech.com/solutions/4/qttestlib/qsignalspy.html

-Benjamin Meyer

-- 
aka icefox
Public Key: http://www.icefox.net/public_key.asc

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]