[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: [patch] minicli resizeable
From: Martin Koller <m.koller () surfeu ! at>
Date: 2005-09-05 17:54:52
Message-ID: 200509051954.56911.m.koller () surfeu ! at
[Download RAW message or body]
On Monday 05 September 2005 10:56, Christian Esken wrote:
> Am Sonntag, 4. September 2005 15:50 schrieb Martin Koller:
> > Hi,
> >
> > I try again to offer a patch (3.5) which allows minicli to be resizeable
> > - without the problem of an ever growing combobox.
> > (https://bugs.kde.org/show_bug.cgi?id=112020)
> > I work with this patch now for almost a year (applied locally again and
> > again ...) without problems.
> > Are there good reasons to not allow this in ?
>
> Just some questions. Why have you decided to change the width and height
> and sizeHint (80 =>250) in minicli_ui.ui ? And what does mean the change in
> hsizetype (7 => 5).
The change in size was a leftover from my modifications a year ago ...
I changed the size back in the ui file, but it does not make a difference in
the behaviour.
The hsizetype 7 => 5 change is QSizePolicy::Expanding =>
QSizePolicy::Preferred.
>
> Otherwise the patch looks fine ( sizeHint() sounds so much more sensible
> than setMaxCommandBoxWidth() ). If it works as good as claimed, lets get it
> in.
OK, committed.
--
Best regards/Schöne Grüße
Martin () ascii ribbon campaign - against html mail
/\ - against microsoft attachments
Some operating systems are called 'user friendly',
Linux however is 'expert friendly'.
[Attachment #3 (application/pgp-signature)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic