[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Emit warnings from Job,
From:       Adriaan de Groot <groot () kde ! org>
Date:       2005-07-13 20:42:47
Message-ID: 200507132242.47827.groot () kde ! org
[Download RAW message or body]

On Wednesday 13 July 2005 18:23, Kévin Ottens wrote:
> Could someone review the attached patch?

Drat, I was getting all ready to bitch about missing API dox (as is my wont) 
and then I actually read the patch. Hats off, Kévin, to your diligence. Would 
that more people took such care with their interfaces and documentation.

(So the _dox_ part of the patch is fine. I can't say about the functionality.)

-- 
These are your friends - Adem
    GPG: FEA2 A3FE Adriaan de Groot

[prev in list] [next in list] [prev in thread] [next in thread]