[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    About --enable-new-ldflags
From:       Szombathelyi "György" <gyurco () freemail ! hu>
Date:       2005-07-04 18:56:08
Message-ID: 200507042100.16490.gyurco () freemail ! hu
[Download RAW message or body]

Hi!

The --enable-new-ldflags is a very good switch to reduce kde dependencies. 
However there are some places where $(all_libraries) missing, so the 
neccessary flags are not added to the linking process. The attached patches 
fix this.
And after all, why not --disable-new-ldflags? It seems that few (or no) 
packagers are using this flag, enabling this by default should not harm.

Bye,
György

____________________________________________________________________
Miert fizetsz az internetert? Korlatlan, ingyenes internet hozzaferes a FreeStarttol.
Probald ki most! http://www.freestart.hu

["kdenetwork.diff" (text/x-diff)]

Index: kopete/plugins/nowlistening/Makefile.am
===================================================================
--- kopete/plugins/nowlistening/Makefile.am	(revision 431277)
+++ kopete/plugins/nowlistening/Makefile.am	(working copy)
@@ -5,7 +5,7 @@
 kde_module_LTLIBRARIES = kopete_nowlistening.la kcm_kopete_nowlistening.la
 
 kopete_nowlistening_la_SOURCES = nowlisteningconfig.cpp nowlisteningplugin.cpp \
nlkscd.cpp nlnoatun.cpp nlxmms.cpp nowlisteningguiclient.cpp nljuk.cpp nlamarok.cpp \
                nlkaffeine.cpp
-kopete_nowlistening_la_LDFLAGS     = -module $(KDE_PLUGIN) $(XMMS_LDFLAGS)
+kopete_nowlistening_la_LDFLAGS     = -module $(KDE_PLUGIN) $(XMMS_LDFLAGS) \
$(all_libraries)  kopete_nowlistening_la_LIBADD      = ../../libkopete/libkopete.la \
$(XMMS_LIBS)  
 kcm_kopete_nowlistening_la_SOURCES = nowlisteningprefs.ui \
                nowlisteningpreferences.cpp nowlisteningconfig.cpp
Index: kopete/plugins/smpppdcs/Makefile.am
===================================================================
--- kopete/plugins/smpppdcs/Makefile.am	(revision 431277)
+++ kopete/plugins/smpppdcs/Makefile.am	(working copy)
@@ -13,7 +13,7 @@
 kde_module_LTLIBRARIES = kopete_smpppdcs.la
 
 kopete_smpppdcs_la_SOURCES = smpppdcsplugin.cpp
-kopete_smpppdcs_la_LDFLAGS = -module $(KDE_PLUGIN)
+kopete_smpppdcs_la_LDFLAGS = -module $(KDE_PLUGIN) $(all_libraries)
 kopete_smpppdcs_la_LIBADD  = ../../libkopete/libkopete.la -lcrypto
 
 service_DATA = kopete_smpppdcs.desktop
Index: kopete/plugins/statistics/Makefile.am
===================================================================
--- kopete/plugins/statistics/Makefile.am	(revision 431277)
+++ kopete/plugins/statistics/Makefile.am	(working copy)
@@ -8,7 +8,7 @@
 
 kopete_statistics_la_SOURCES = statisticsplugin.cpp statisticsdb.cpp \
statisticsdialog.cpp statisticswidget.ui statisticscontact.cpp \
statisticsdcopiface.skel  
-kopete_statistics_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN)
+kopete_statistics_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN) \
$(all_libraries)  kopete_statistics_la_LIBADD      = ../../libkopete/libkopete.la \
sqlite/libsqlite.la  
 service_DATA = kopete_statistics.desktop
Index: kopete/plugins/cryptography/Makefile.am
===================================================================
--- kopete/plugins/cryptography/Makefile.am	(revision 431277)
+++ kopete/plugins/cryptography/Makefile.am	(working copy)
@@ -7,7 +7,7 @@
 kde_module_LTLIBRARIES = kopete_cryptography.la kcm_kopete_cryptography.la
 
 kopete_cryptography_la_SOURCES     = cryptographyplugin.cpp kgpginterface.cpp \
cryptographyguiclient.cpp cryptographyselectuserkey.cpp cryptographyuserkey_ui.ui \
                popuppublic.cpp kgpgselkey.cpp
-kopete_cryptography_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN)
+kopete_cryptography_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN) \
$(all_libraries)  kopete_cryptography_la_LIBADD      = ../../libkopete/libkopete.la
 
 kcm_kopete_cryptography_la_SOURCES = cryptographypreferences.cpp \
                cryptographyprefsbase.ui  kgpgselkey.cpp
Index: kopete/plugins/netmeeting/Makefile.am
===================================================================
--- kopete/plugins/netmeeting/Makefile.am	(revision 431277)
+++ kopete/plugins/netmeeting/Makefile.am	(working copy)
@@ -5,7 +5,7 @@
 kde_module_LTLIBRARIES = kopete_netmeeting.la kcm_kopete_netmeeting.la
 
 kopete_netmeeting_la_SOURCES     = netmeetingplugin.cpp netmeetinginvitation.cpp \
                netmeetingguiclient.cpp
-kopete_netmeeting_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN)
+kopete_netmeeting_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN) \
$(all_libraries)  kopete_netmeeting_la_LIBADD      = \
$(top_builddir)/kopete/libkopete/libkopete.la \
$(top_builddir)/kopete/protocols/msn/libkopete_msn_shared.la  
 service_DATA = kopete_netmeeting.desktop
Index: kopete/plugins/texteffect/Makefile.am
===================================================================
--- kopete/plugins/texteffect/Makefile.am	(revision 431277)
+++ kopete/plugins/texteffect/Makefile.am	(working copy)
@@ -6,7 +6,7 @@
 kde_module_LTLIBRARIES = kopete_texteffect.la kcm_kopete_texteffect.la
 
 kopete_texteffect_la_SOURCES     = texteffectplugin.cpp texteffectconfig.cpp
-kopete_texteffect_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN)
+kopete_texteffect_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN) \
$(all_libraries)  kopete_texteffect_la_LIBADD      = ../../libkopete/libkopete.la
 
 kcm_kopete_texteffect_la_SOURCES = texteffectconfig.cpp texteffectprefs.ui \
                texteffectpreferences.cpp
Index: kopete/plugins/history/Makefile.am
===================================================================
--- kopete/plugins/history/Makefile.am	(revision 431277)
+++ kopete/plugins/history/Makefile.am	(working copy)
@@ -7,7 +7,7 @@
 kopete_history_la_SOURCES = historyplugin.cpp historydialog.cpp historyviewer.ui\
 	historylogger.cpp converter.cpp historyguiclient.cpp historyconfig.kcfgc
 
-kopete_history_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN)
+kopete_history_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN) $(all_libraries)
 kopete_history_la_LIBADD      = ../../libkopete/libkopete.la
 
 kcm_kopete_history_la_SOURCES = historyprefsui.ui historypreferences.cpp  \
                historyconfig.kcfgc
Index: kopete/plugins/webpresence/Makefile.am
===================================================================
--- kopete/plugins/webpresence/Makefile.am	(revision 431277)
+++ kopete/plugins/webpresence/Makefile.am	(working copy)
@@ -6,7 +6,7 @@
 
 kopete_webpresence_la_SOURCES     = webpresenceplugin.cpp
 
-kopete_webpresence_la_LDFLAGS     = -module  -no-undefined $(KDE_PLUGIN)
+kopete_webpresence_la_LDFLAGS     = -module  -no-undefined $(KDE_PLUGIN) \
$(all_libraries)  kopete_webpresence_la_LIBADD      = ../../libkopete/libkopete.la \
$(LIBXML_LIBS) $(LIBXSLT_LIBS)  
 kcm_kopete_webpresence_la_SOURCES = webpresencepreferences.cpp webpresenceprefs.ui
Index: kopete/plugins/connectionstatus/Makefile.am
===================================================================
--- kopete/plugins/connectionstatus/Makefile.am	(revision 431277)
+++ kopete/plugins/connectionstatus/Makefile.am	(working copy)
@@ -5,7 +5,7 @@
 kde_module_LTLIBRARIES = kopete_connectionstatus.la
 
 kopete_connectionstatus_la_SOURCES     = connectionstatusplugin.cpp
-kopete_connectionstatus_la_LDFLAGS     = -module $(KDE_PLUGIN)
+kopete_connectionstatus_la_LDFLAGS     = -module $(KDE_PLUGIN) $(all_libraries)
 kopete_connectionstatus_la_LIBADD      = ../../libkopete/libkopete.la
 
 service_DATA = kopete_connectionstatus.desktop
Index: kopete/plugins/highlight/Makefile.am
===================================================================
--- kopete/plugins/highlight/Makefile.am	(revision 431277)
+++ kopete/plugins/highlight/Makefile.am	(working copy)
@@ -7,7 +7,7 @@
 kde_module_LTLIBRARIES = kopete_highlight.la kcm_kopete_highlight.la
 
 kopete_highlight_la_SOURCES = highlightplugin.cpp highlightconfig.cpp filter.cpp
-kopete_highlight_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN)
+kopete_highlight_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN) \
$(all_libraries)  kopete_highlight_la_LIBADD      = ../../libkopete/libkopete.la
 
 kcm_kopete_highlight_la_SOURCES = highlightprefsbase.ui highlightpreferences.cpp \
                filter.cpp highlightconfig.cpp
Index: kopete/plugins/latex/Makefile.am
===================================================================
--- kopete/plugins/latex/Makefile.am	(revision 431277)
+++ kopete/plugins/latex/Makefile.am	(working copy)
@@ -7,7 +7,7 @@
 kde_module_LTLIBRARIES = kopete_latex.la kcm_kopete_latex.la
 
 kopete_latex_la_SOURCES = latexplugin.cpp latexconfig.kcfgc latexguiclient.cpp
-kopete_latex_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN)
+kopete_latex_la_LDFLAGS     = -module -no-undefined $(KDE_PLUGIN) $(all_libraries)
 kopete_latex_la_LIBADD      = ../../libkopete/libkopete.la
 
 kcm_kopete_latex_la_SOURCES = latexprefsbase.ui latexpreferences.cpp \
                latexconfig.kcfgc
Index: kopete/protocols/yahoo/Makefile.am
===================================================================
--- kopete/protocols/yahoo/Makefile.am	(revision 431277)
+++ kopete/protocols/yahoo/Makefile.am	(working copy)
@@ -11,7 +11,7 @@
 kopete_yahoo_la_SOURCES = yahooprotocol.cpp kyahoo.cpp yahoocontact.cpp \
 	yahooaddcontact.cpp yahooaccount.cpp yahooeditaccount.cpp \
yahooconferencemessagemanager.cpp \  yahoouserinfo.cpp yahoobuddyiconloader.cpp \
                yahoochatsession.cpp yahoochatsession.h
-kopete_yahoo_la_LDFLAGS     = -module $(KDE_PLUGIN)
+kopete_yahoo_la_LDFLAGS     = -module $(KDE_PLUGIN) $(all_libraries)
 kopete_yahoo_la_LIBADD      = $(top_builddir)/kopete/libkopete/libkopete.la  \
ui/libkopeteyahooui.la libyahoo2/libyahoo2.la  
 service_DATA = kopete_yahoo.desktop
Index: knewsticker/kntsrcfilepropsdlg/kntsrcfilepropsdlgwidget.ui
===================================================================
--- knewsticker/kntsrcfilepropsdlg/kntsrcfilepropsdlgwidget.ui	(revision 431277)
+++ knewsticker/kntsrcfilepropsdlg/kntsrcfilepropsdlgwidget.ui	(working copy)
@@ -1,4 +1,4 @@
-<!DOCTYPE UI><UI version="3.3" stdsetdef="1">
+<!DOCTYPE UI><UI>
 <class>KntSrcFilePropsDlgWidget</class>
 <comment>The widget to be used for the RDF/RSS file properties dialog \
plugin.</comment>  <author>Frerich Raabe &lt;raabe@kde.org&gt;</author>


["kdepim.diff" (text/x-diff)]

Index: kresources/remote/Makefile.am
===================================================================
--- kresources/remote/Makefile.am	(revision 431277)
+++ kresources/remote/Makefile.am	(working copy)
@@ -10,7 +10,7 @@
 kde_module_LTLIBRARIES = kcal_remote.la
 
 kcal_remote_la_SOURCES = resourceremote_plugin.cpp
-kcal_remote_la_LDFLAGS = -module $(KDE_PLUGIN)
+kcal_remote_la_LDFLAGS = $(all_libraries) -module $(KDE_PLUGIN)
 kcal_remote_la_LIBADD  = libkcal_resourceremote.la \
                          $(top_builddir)/libkdepim/libkdepim.la
 
Index: kitchensync/libkonnector2/plugins/qtopia/Makefile.am
===================================================================
--- kitchensync/libkonnector2/plugins/qtopia/Makefile.am	(revision 431277)
+++ kitchensync/libkonnector2/plugins/qtopia/Makefile.am	(working copy)
@@ -25,7 +25,7 @@
 
 libqtopiakonnector_la_INCLUDES = -I$(top_srcdir)/kitchensync/libkonnector2 \
-I$(top_srcdir)/kitchensync/libksync -I../../   $(all_includes)  \
                libqtopiakonnector_la_LIBADD = ../../libkonnector.la 
-libqtopiakonnector_la_LDFLAGS = -module $(KDE_PLUGIN) 
+libqtopiakonnector_la_LDFLAGS = $(all_libraries) -module $(KDE_PLUGIN) 
 libqtopiakonnector_la_SOURCES = qtopiakonnector.cpp socket.cpp addressbook.cpp \
 				categoryedit.cpp datebook.cpp helper.cpp \
 				opiecategories.cpp todo.cpp desktop.cpp \
Index: libkcal/Makefile.am
===================================================================
--- libkcal/Makefile.am	(revision 431277)
+++ libkcal/Makefile.am	(working copy)
@@ -54,15 +54,15 @@
 kde_module_LTLIBRARIES = kcal_local.la kcal_localdir.la kcal_kabc.la
 
 kcal_local_la_SOURCES = resourcelocal_plugin.cpp
-kcal_local_la_LDFLAGS = -module $(KDE_PLUGIN)
+kcal_local_la_LDFLAGS = $(all_libraries) -module $(KDE_PLUGIN)
 kcal_local_la_LIBADD  = libkcal.la
 
 kcal_localdir_la_SOURCES = resourcelocaldir_plugin.cpp
-kcal_localdir_la_LDFLAGS = -module $(KDE_PLUGIN)
+kcal_localdir_la_LDFLAGS = $(all_libraries) -module $(KDE_PLUGIN)
 kcal_localdir_la_LIBADD  = libkcal.la
 
 kcal_kabc_la_SOURCES = resourcekabc.cpp resourcekabcconfig.cpp
-kcal_kabc_la_LDFLAGS = -module $(KDE_PLUGIN)
+kcal_kabc_la_LDFLAGS = $(all_libraries) -module $(KDE_PLUGIN)
 kcal_kabc_la_LIBADD  = libkcal.la
 
 EXTRA_PROGRAMS = convertqtopia
Index: knotes/Makefile.am
===================================================================
--- knotes/Makefile.am	(revision 431277)
+++ knotes/Makefile.am	(working copy)
@@ -29,7 +29,7 @@
 
 kde_module_LTLIBRARIES  = knotes_local.la
 knotes_local_la_SOURCES = resourcelocal_plugin.cpp
-knotes_local_la_LDFLAGS = $(KDE_LDFLAGS) -module $(KDE_PLUGIN)
+knotes_local_la_LDFLAGS = $(KDE_LDFLAGS) $(all_libraries) -module $(KDE_PLUGIN)
 knotes_local_la_LIBADD  = libknotesresources.la libknotesconfig.la \
                           $(top_builddir)/libkcal/libkcal.la -lkdeprint
 



[prev in list] [next in list] [prev in thread] [next in thread]