[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: klistviewsearchline
From:       Daniel Teske <teske () squorn ! de>
Date:       2005-07-03 16:52:57
Message-ID: 200507031852.57652.teske () squorn ! de
[Download RAW message or body]

> > I think it's correct.
> I think so too. 
Good

> Comments on the patch follow.
Thanks.

> Don't check this in.
Right

> Or this.
Errf, I thought, I had cleaned up.

> This line is redundant, since findFirstHiddenToVisible does this
> anyway. It's confusing to have this here, since it looks like it
> makes all the children of item visible (whereas it actually does
> nothing).
Right.

> Is this supposed to be part of the same patch? If so, can you explain
> it?
That's a fix for a different bug. Sorry for the confusion.

daniel
[prev in list] [next in list] [prev in thread] [next in thread]