[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    kdemm configure check weirdness
From:       Adriaan de Groot <groot () kde ! org>
Date:       2005-07-03 10:43:24
Message-ID: 200507031243.25085.groot () kde ! org
[Download RAW message or body]

The following line in kde-multimedia's configure.in.in looks really weird:

if eval "test \"`echo `$ac_cv_x86_sse\" = yes"; then

it certainly triggers some configure failures on FreeBSD 4-stable (but not 
elsewhere). Wouldn't it be simpler to just check the value of the variable, 
as the attached patch does? (Me, I'm not sure any of my machines _have_ SSE, 
so I can't particularly test.)

-- 
These are your friends - Adem
    GPG: FEA2 A3FE Adriaan de Groot

["kdemm.diff" (text/x-diff)]

Index: configure.in.in
===================================================================
--- configure.in.in	(revision 429635)
+++ configure.in.in	(working copy)
@@ -83,7 +83,7 @@
 ac_cv_x86_sse=no)
 ])
 AC_MSG_RESULT($ac_cv_x86_sse)
-if eval "test \"`echo `$ac_cv_x86_sse\" = yes"; then
+if test "x$ac_cv_x86_sse" = "xyes"; then
 	    AC_DEFINE(HAVE_X86_SSE,1,
 		        [Define if your assembler supports x86 SSE instructions])
 fi


[prev in list] [next in list] [prev in thread] [next in thread]