[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KUnitTest CVS
From:       "Duncan Mac-Vicar P." <duncan () kde ! org>
Date:       2005-05-03 21:58:38
Message-ID: 200505031758.38528.duncan () kde ! org
[Download RAW message or body]


There are some issues with QT_NOASCII_CAST (used in Kopete)

static const QString s_kunittest_suite = "Suite"

and then when calling a function, you mix const char * and QStrings...

test->setName(s_kunittest_suite + "::" + "KopeteLinkTest")

This will not compile with QT_NOASCII_CAST, You will get errors like:
error: cannot convert `const QString' to `const char*' for argument `1' to 
`void kunittest_registerModuleTester(const char*, KUnitTest::Tester*)'
- you should explicitly do the conversion. 
test->setName(s_kunittest_suite + "::" + QString::fromLatin1
("KopeteLinkTest")) in this case. I would fix it myself but CVS is readonly 
today and your code is still not in cvs/svn.

We had similar problems with Ian's widget compiler, which are fixed.
Everyone generating code from macros and compilers please take QT_NOASCII_CAST 
in count ;-)

Cheers
Duncan
[prev in list] [next in list] [prev in thread] [next in thread]