[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Hspell plugin for KSpell2
From:       Mashrab Kuvatov <kmashrab () sat ! physik ! uni-bremen ! de>
Date:       2005-04-29 14:53:22
Message-ID: 200504291653.29316.kmashrab () sat ! physik ! uni-bremen ! de
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


Hi Meni, Dan, and everyone,

> Though I haven't yet tested the patch, there may be a problem at
> HSpellDict's
>
> constructor:
> > +    /* hspell understans only iso8859-8              */
> > +    codec = QTextCodec::codecForName( "iso8859-8" );
>
> The codec should be actually "iso8859-8-i", otherwise words would get sent
> to hspell reversed. This may be the cause of the problems that Dan brought
> up in his reply.

Yes that was it. Thanks. In addition, in HSpellDict::check
"return correct != 1" was also wrong. It should be "return correct == 1". I
have updated a patch.

The shots [1] and [2] show the patch in action. Does it make sense now? I
deleted couple of characters of one word. Sorry, if it means something bad in
your language.

1.http://www.uni-bremen.de/~kmashrab/images/kpresenter-kspell2-hspell-auto-fixed.png
2.http://www.uni-bremen.de/~kmashrab/images/kpresenter-kspell2-hspell-fixed.png

Have a nice weekend,
Mashrab.

-- 
Mashrab Kuvatov
Ph.D student
University of Bremen, IUP
Home-page: www.sat.uni-bremen.de/members/mashrab
PGP key: www.uni-bremen.de/~kmashrab/kmashrab.asc

["kspell2-hspell.patch.bz2" (application/x-bzip2)]
[Attachment #6 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]