[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KSaveFile::abort() on win32
From:       Jaroslaw Staniek <js () iidea ! pl>
Date:       2005-03-30 20:40:02
Message-ID: 424B1CEE.3090908 () iidea ! pl
[Download RAW message or body]






> On Wednesday 30 March 2005 17:30, Oswald Buddenhagen wrote:
> 
>>On Wed, Mar 30, 2005 at 04:58:10PM +0100, Jaroslaw Staniek wrote:
>>
>>>+++ ksavefile.cpp	30 Mar 2005 14:53:05 -0000
>>>@@ -99,8 +99,17 @@
>>> void
>>> KSaveFile::abort()
>>> {
>>>+#ifdef Q_WS_WIN
>>>+   //for win32: close before unlinking
>>>+   QString tmpName( mTempFile.name() );
>>>+#else
>>>    mTempFile.unlink();
>>>+#endif
>>>    mTempFile.close();
>>>+#ifdef Q_WS_WIN
>>>+   if (!tmpName.isEmpty())
>>>+      QFile::remove( tmpName );
>>>+#endif
>>> }
>>
>>i think in this case the order is not relevant, so just close it before
>>unlinking unconditionally, i'd say. waldo?
> 
> 
> I agree.

OK, it looked more "atomical" for me on unix but it was only impression...

-- 
regards / pozdrawiam,
  Jaroslaw Staniek / OpenOffice Polska / Kexi Team
  http://www.openoffice.com.pl  |  http://www.kexi-project.org
  KDElibs/Windows: http://wiki.kde.org/tiki-index.php?page=KDElibs+for+win32
[prev in list] [next in list] [prev in thread] [next in thread]