From kde-core-devel Wed Mar 30 15:30:25 2005 From: Oswald Buddenhagen Date: Wed, 30 Mar 2005 15:30:25 +0000 To: kde-core-devel Subject: Re: [PATCH] KSaveFile::abort() on win32 Message-Id: <20050330153025.GA12400 () ugly ! local> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=111219662810393 On Wed, Mar 30, 2005 at 04:58:10PM +0100, Jaroslaw Staniek wrote: > +++ ksavefile.cpp 30 Mar 2005 14:53:05 -0000 > @@ -99,8 +99,17 @@ > void > KSaveFile::abort() > { > +#ifdef Q_WS_WIN > + //for win32: close before unlinking > + QString tmpName( mTempFile.name() ); > +#else > mTempFile.unlink(); > +#endif > mTempFile.close(); > +#ifdef Q_WS_WIN > + if (!tmpName.isEmpty()) > + QFile::remove( tmpName ); > +#endif > } > i think in this case the order is not relevant, so just close it before unlinking unconditionally, i'd say. waldo? -- Hi! I'm a .signature virus! Copy me into your ~/.signature, please! -- Chaos, panic, and disorder - my work here is done.