From kde-core-devel  Thu Mar 24 23:07:10 2005
From: Michael Ritzert <kde () ritzert ! de>
Date: Thu, 24 Mar 2005 23:07:10 +0000
To: kde-core-devel
Subject: Re: patches to compile on Solaris
Message-Id: <20050324230709.GB16100 () moonlight ! mailsys ! de>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=111170598213272

On Thu, Mar 24, 2005 at 11:55:39PM +0100, Dirk Mueller wrote:
> On Thursday 24 March 2005 23:42, Michael Ritzert wrote:
> 
> > Or is the preferred way to use
> > #ifdef s_addr
> > #  undef s_addr
> > #endif
> > ?
> 
> thats usually the preferred way, but in this case renaming to s_address even 
> increases the readability, so I would prefer the rename. 

Ok. I just checked in the patch renaming s_addr to s_address. I will
chose the #undef style when there is no increase in readability to be
obtained from a renaming.
Any preferences on where to place the #undef block? In front of the
function that needs it or at the beginning of the file?

Michael