[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] win32 paths-related fixes
From:       Waldo Bastian <bastian () kde ! org>
Date:       2005-02-11 16:51:20
Message-ID: 200502111751.24769.bastian () kde ! org
[Download RAW message or body]


In the chunk below

@@ -1217,7 +1225,7 @@
 
 KURL KCmdLineArgs::makeURL( const char *urlArg )
 {
-   if (*urlArg == '/')
+   if (!QDir::isRelativePath(urlArg))
    {
       KURL result;
       result.setPath(QFile::decodeName( urlArg));

you may want to do something like this instead:

@@ -1226,10 +1226,11 @@ KCmdLineArgs::url(int n) const

 KURL KCmdLineArgs::makeURL( const char *urlArg )
 {
-   if (*urlArg == '/')
+   QString _urlArg = QFile::decodeName( urlArg);
+   if (!QDir::isRelativePath(_urlArg))
    {
       KURL result;
-      result.setPath(QFile::decodeName( urlArg));
+      result.setPath(_urlArg);
       return result; // Absolute path.
    }
@@ -1237,7 +1238,7 @@ KURL KCmdLineArgs::makeURL( const char *
      return KURL(QString::fromLocal8Bit(urlArg)); // Argument is a URL

    KURL result;
-   result.setPath( cwd()+"/"+QFile::decodeName( urlArg ));
+   result.setPath( cwd()+"/"+_urlArg);
    result.cleanPath();
    return result;  // Relative path
 }

Cheers,
Waldo
-- 
bastian@kde.org   |   Free Novell Linux Desktop 9 Evaluation Download
bastian@suse.com  |   http://www.novell.com/products/desktop/eval.html

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]