[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] dcopidl - accepting '\r' characters
From:       Thiago Macieira <thiago.macieira () kdemail ! net>
Date:       2005-02-11 10:58:16
Message-ID: 200502110858.24326.thiago.macieira () kdemail ! net
[Download RAW message or body]


Jarosław Staniek wrote:
>qFatal() was raised because of unrecognizable character '\r'.
>These characters may usually come from macosx or win32 environments.
>Since macosx and win32 KDE developemnt became something real, there may
> exist (at least by accident) source files with '\r' character. My patch
> accepts them by removing before parsing, as C/C++ preprocessors do.
>
>Ok to commit?

Isn't it possible to condense \r\n into \n instead? I don't think simply 
eating all \r is healthy.

Stray \r in the source code is certainly corrupted file.

BTW, doesn't Mac use \r alone as its line-breaking character? If so, maybe 
tr/\r/\n/ is the way to go, since whitespaces are whitespaces anywhere.
-- 
  Thiago Macieira  -  thiago (AT) macieira (DOT) info
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

1. On frumscafte, hwonne time_t wæs náht, se scieppend þone circolwyrde 
wundorcræftlíge cennede and seo eorðe wæs idel and hit wæs gód.

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]