[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] media:/ mount point info
From:       Martin Koller <m.koller () surfeu ! at>
Date:       2005-01-31 21:38:36
Message-ID: 200501312238.40772.m.koller () surfeu ! at
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On Monday 31 January 2005 17:54, Kévin Ottens wrote:
> In order to commit it and address bug 95646 (fully), you should slightly
> modify it :
> 1) Add the device node information

I wanted to do that, but don't know from where I get the information.

> 2) Be careful when you fill the information, sometimes mount point or
> device node are not available, in this case you should not display the
> information since it's an empty string.

OK, I addressed that, but am not sure. If mount_point is an empty string, 
would 
	df->readDF(mount_point);
work correctly ?

As I will be not able to add the device information before the freeze (I'm 
abroad the next 2 days) it would be great if you can add the device node 
information before the freeze and commit then
(or if you don't have time, please commit at least this version, if ok)
Thanks.

Attached is the modified version.

-- 
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail 
          /\                        - against microsoft attachments

       Some operating systems are called 'user friendly',
             Linux however is 'expert friendly'.

["mountPoint.patch" (text/x-diff)]

Index: kfilemediaplugin.cpp
===================================================================
RCS file: /home/kde/kdebase/kioslave/media/kfile-plugin/kfilemediaplugin.cpp,v
retrieving revision 1.2
diff -u -3 -p -r1.2 kfilemediaplugin.cpp
--- kfilemediaplugin.cpp	15 Jan 2005 21:39:14 -0000	1.2
+++ kfilemediaplugin.cpp	31 Jan 2005 21:37:22 -0000
@@ -87,6 +87,9 @@ bool KFileMediaPlugin::readInfo(KFileMet
 	appendItem(group, "used", (long long unsigned)m_used);
 	appendItem(group, "total", (long long unsigned)m_total);
 
+	if ( !mount_point.isEmpty() )
+		appendItem(group, "mountPoint", mount_point);
+
 	group = appendGroup(info, "mediumSummary");
 
 	appendItem(group, "percent", QString("%1\%").arg(percent));
@@ -152,6 +155,7 @@ void KFileMediaPlugin::addMimeType(const
 	item = addItemInfo(group, "total", i18n("Total"), QVariant::Int);
 	setUnit(item, KFileMimeTypeInfo::KiloBytes);
 
+	item = addItemInfo(group, "mountPoint", i18n("Mount Point"), QVariant::String);
 
 	group = addGroupInfo(info, "mediumSummary", i18n("Medium Summary"));
 

[Attachment #6 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]