[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Sharing emoticons themes between Kopete and Konversation.
From:       Olivier Goffart <ogoffart () tiscalinet ! be>
Date:       2005-01-07 22:08:37
Message-ID: 200501072308.37965.ogoffart () tiscalinet ! be
[Download RAW message or body]

Le Vendredi 7 Janvier 2005 16:20, Ingo Klöcker a écrit :
> On Friday 07 January 2005 15:47, Waldo Bastian wrote:
> > On Friday 07 January 2005 15:34, Olivier Goffart wrote:

> > > That's why i suggest placing emoticons in  $KDEDIR/share/emoticons
> > > is that ok ?
> >
> > I think so.
>
> I second this.

I've attached a patch to kdecore which enable that directory.
(i've posted more patch for kopete in the kopete mailing list)


> > > And most emoticons theme should probably be placed in kdeartwork.
> > > keeping only the default one in kdenetwork with kopete.
> >
> > I would move the default one to kdelibs then actually. That way
> > Konversation doesn't need to depend on Kopete for its icons.

Ok

> And eventually KMail will also support emoticons (there's already a
> patch for this and it's even on the feature plan for 3.4).

nice.  

> > Is there a document that describes how these themes look like? You may
> > wish  to  submit that to freedesktop.org.  

I just done it.

["emoticons_kdecore.diff" (text/x-diff)]

Index: kstandarddirs.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kstandarddirs.cpp,v
retrieving revision 1.192
diff -u -p -b -B -r1.192 kstandarddirs.cpp
--- kstandarddirs.cpp	22 Dec 2004 20:18:12 -0000	1.192
+++ kstandarddirs.cpp	7 Jan 2005 19:20:46 -0000
@@ -100,7 +100,7 @@ static const char* const types[] = {"htm
 			      "wallpaper", "lib", "pixmap", "templates",
 			      "module", "qtplugins",
 			      "xdgdata-apps", "xdgdata-dirs", "xdgconf-menu",
-                              "kcfg", 0 };
+			      "kcfg", "emoticons", 0 };
 
 static int tokenize( QStringList& token, const QString& str,
 		const QString& delim );
@@ -1061,6 +1061,10 @@ QString KStandardDirs::kde_default(const
         return "menus/";
     if (!strcmp(type, "kcfg"))
 	return "share/config.kcfg";
+    if (!strcmp(type, "emoticons"))
+			return "share/emoticons";
+
+
     qFatal("unknown resource type %s", type);
     return QString::null;
 }
Index: kstandarddirs.h
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kstandarddirs.h,v
retrieving revision 1.121
diff -u -p -b -B -r1.121 kstandarddirs.h
--- kstandarddirs.h	3 Dec 2004 11:12:51 -0000	1.121
+++ kstandarddirs.h	7 Jan 2005 19:20:46 -0000
@@ -90,6 +90,7 @@ class KStandardDirsPrivate;
  * @li wallpaper - Wallpapers.
  * @li tmp - Temporary files (specific for both current host and current user)
  * @li socket - UNIX Sockets (specific for both current host and current user)
+ * @li emoticons - Emoticons themes
  *
  * A type that is added by the class KApplication if you use it, is
  * appdata. This one makes the use of the type data a bit easier as it


[prev in list] [next in list] [prev in thread] [next in thread]